Skip to content

plugins.kick: low latency#6605

Merged
bastimeyer merged 2 commits intostreamlink:masterfrom
lbrooney:plugins/kick/low-latency
Jul 10, 2025
Merged

plugins.kick: low latency#6605
bastimeyer merged 2 commits intostreamlink:masterfrom
lbrooney:plugins/kick/low-latency

Conversation

@lbrooney
Copy link
Copy Markdown
Contributor

Adds low latency mode to the Kick plugin. Implemented by porting over the functionality from the Twitch plugin without the ad filtering parts. I also ported what I felt were the relevant tests for this feature from the Twitch tests.

@bastimeyer bastimeyer added the plugin enhancement A new feature for a working Plugin label Jul 10, 2025
Copy link
Copy Markdown
Member

@bastimeyer bastimeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Apart from some minor nitpicks, this looks good.

Having duplicate code for this isn't ideal considering that Kick is basically using the same custom HLS additions as Twitch, as they're using Amazon's infrastructure, but I guess there's not much that can be done here. Both plugins relying on a common HLS implementation doesn't make sense either.

The plugin file could have a low latency note added to its metadata in the header, but it's not necessary, as the plugin argument already covers this. The Twitch plugin has a note there because it links to the dedicated Twitch plugin page in the docs.

Comment thread src/streamlink/plugins/kick.py Outdated
Comment thread src/streamlink/plugins/kick.py Outdated
Comment thread src/streamlink/plugins/kick.py Outdated
Comment thread src/streamlink/plugins/kick.py Outdated
Comment thread src/streamlink/plugins/kick.py Outdated
Co-authored-by: Sebastian Meyer <mail@bastimeyer.de>
@lbrooney
Copy link
Copy Markdown
Contributor Author

Thanks for the suggestions!

When I was porting over the feature, I did wonder if there were a way to make a generic Amazon IVS solution, but that is far out of my knowledge or expertise to comment deeply on.

I was unsure whether this warranted a seperate page, but as you said the plugin argument likely sufficiently covers this.

@bastimeyer bastimeyer merged commit 19ead7e into streamlink:master Jul 10, 2025
27 checks passed
@bastimeyer
Copy link
Copy Markdown
Member

Thanks!

@lbrooney lbrooney deleted the plugins/kick/low-latency branch July 11, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugin enhancement A new feature for a working Plugin

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants