plugins.kick: low latency#6605
Conversation
bastimeyer
left a comment
There was a problem hiding this comment.
Thanks. Apart from some minor nitpicks, this looks good.
Having duplicate code for this isn't ideal considering that Kick is basically using the same custom HLS additions as Twitch, as they're using Amazon's infrastructure, but I guess there's not much that can be done here. Both plugins relying on a common HLS implementation doesn't make sense either.
The plugin file could have a low latency note added to its metadata in the header, but it's not necessary, as the plugin argument already covers this. The Twitch plugin has a note there because it links to the dedicated Twitch plugin page in the docs.
Co-authored-by: Sebastian Meyer <mail@bastimeyer.de>
|
Thanks for the suggestions! When I was porting over the feature, I did wonder if there were a way to make a generic Amazon IVS solution, but that is far out of my knowledge or expertise to comment deeply on. I was unsure whether this warranted a seperate page, but as you said the plugin argument likely sufficiently covers this. |
|
Thanks! |
Adds low latency mode to the Kick plugin. Implemented by porting over the functionality from the Twitch plugin without the ad filtering parts. I also ported what I felt were the relevant tests for this feature from the Twitch tests.