Create durable exchange topic cursor for queue#619
Merged
codelipenghui merged 9 commits intostreamnative:masterfrom Oct 10, 2022
Merged
Create durable exchange topic cursor for queue#619codelipenghui merged 9 commits intostreamnative:masterfrom
codelipenghui merged 9 commits intostreamnative:masterfrom
Conversation
575320c to
01a0109
Compare
codelipenghui
approved these changes
Oct 10, 2022
Collaborator
Author
|
I create a PR #698 to fix the exchange data cleanup problem. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, for AoP, messages of the queue topic are only index data, the original data are in the exchange topic, the AmqpConsumer needs to get the original message data from the exchange topic and send it to the client, if messages in the exchange topic are clean up, the AmqpConsumer will not get the data, so queue topics need durable cursors of exchange topic to make sure the original data exists.
Notable
This PR will cause the exchange topic can't be cleaned up because the queue only handles part of the exchange data, only these index positions could be acknowledged. I'll create a new PR to fix this problem.
Modifications
Create durable cursors of the exchange topic for each queue in an async way.
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below.
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)