feat(sn-console): align streamnative-console with sn-platform-slim#1267
feat(sn-console): align streamnative-console with sn-platform-slim#1267
Conversation
- Add DB_BASE=sqlite when image tag ends with -all - Add extraEnv for custom environment variables - Add dbPasswordSecret: mount secret as files, read DB_PASSWORD/NEW_PASSWORD in startup script Made-with: Cursor
|
@tuteng:Thanks for your contribution. For this PR, do we need to update docs? |
github-actions
bot
added
the
doc-info-missing
There was a problem hiding this comment.
Pull request overview
This PR extends the sn-console Helm chart to support additional runtime configuration for the StreamNative Console container, including optional DB password injection and extra environment variables.
Changes:
- Add
extraEnvvalues to allow users to append arbitrary environment variables to the console container. - Add
dbPasswordSecretvalues and StatefulSet wiring to mount a secret and exposeDB_PASSWORD/NEW_PASSWORDto the entrypoint via a shell wrapper. - Set
DB_BASE=sqliteautomatically when the image tag ends with-all.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| charts/sn-console/values.yaml | Introduces extraEnv and dbPasswordSecret chart values with usage examples. |
| charts/sn-console/templates/console/streamnative-console-statefulset.yaml | Wires extraEnv, conditional DB_BASE, and secret mount + command wrapper for DB password export. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
charts/sn-console/templates/console/streamnative-console-statefulset.yaml
Outdated
Show resolved
Hide resolved
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 344f922efb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
charts/sn-console/templates/console/streamnative-console-statefulset.yaml
Outdated
Show resolved
Hide resolved
Expose CLUSTER_NAME env var in the console StatefulSet and add a values.yaml knob. Set DEFAULT_ENVIRONMENT_SERVICE_URL default for private-cloud-proxy. Made-with: Cursor
Made-with: Cursor
Made-with: Cursor
(If this PR fixes a github issue, please add
Fixes #<xyz>.)Fixes #
(or if this PR is one task of a github issue, please add
Master Issue: #<xyz>to link to the master issue.)Master Issue: #
Motivation
Explain here the context, and why you're making that change. What is the problem you're trying to solve.
Modifications
Describe the modifications you've done.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation
Check the box below.
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)