Skip to content

Fix: rename oauth mountpath#1275

Merged
tuteng merged 3 commits into
masterfrom
fix/rename-oauth-mountpath
May 11, 2026
Merged

Fix: rename oauth mountpath#1275
tuteng merged 3 commits into
masterfrom
fix/rename-oauth-mountpath

Conversation

@tuteng
Copy link
Copy Markdown
Member

@tuteng tuteng commented May 11, 2026

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

tuteng and others added 3 commits May 11, 2026 15:09
…cret-oauth

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
…rets-oauth

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings May 11, 2026 07:19
@tuteng tuteng requested review from a team as code owners May 11, 2026 07:19
@github-actions
Copy link
Copy Markdown

@tuteng:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@github-actions github-actions Bot added the doc-info-missing This pr needs to mark a document option in description label May 11, 2026
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 16e03d09b4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread charts/sn-platform/templates/_helpers.tpl
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the OAuth broker client credential secret mount path used by the sn-platform and sn-platform-slim Helm charts, aligning the values.yaml examples with the new location. This appears intended to prevent secret mountPath overlap issues (notably when JWT and OAuth are enabled together).

Changes:

  • Renamed the OAuth secret mount path from /mnt/secrets/oauth to /mnt/secrets-oauth in both charts’ _helpers.tpl.
  • Updated the commented brokerClientAuthenticationParameters.privateKey example in both charts’ values.yaml to reference /mnt/secrets-oauth.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

File Description
charts/sn-platform/values.yaml Updates the documented OAuth privateKey example path to match the new mount path.
charts/sn-platform/templates/_helpers.tpl Changes OAuth secret mountPath to /mnt/secrets-oauth.
charts/sn-platform-slim/values.yaml Updates the documented OAuth privateKey example path to match the new mount path.
charts/sn-platform-slim/templates/_helpers.tpl Changes OAuth secret mountPath to /mnt/secrets-oauth.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread charts/sn-platform/templates/_helpers.tpl
Comment thread charts/sn-platform/values.yaml
Comment thread charts/sn-platform/values.yaml
Comment thread charts/sn-platform-slim/templates/_helpers.tpl
Comment thread charts/sn-platform-slim/values.yaml
@tuteng tuteng merged commit 9d0c09b into master May 11, 2026
7 checks passed
@tuteng tuteng deleted the fix/rename-oauth-mountpath branch May 11, 2026 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-info-missing This pr needs to mark a document option in description

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants