This repository was archived by the owner on Jan 24, 2024. It is now read-only.
Fix group id z-node not updated for the same client id#607
Merged
jiazhai merged 1 commit intoJul 8, 2021
Conversation
jiazhai
approved these changes
Jul 8, 2021
BewareMyPower
added a commit
that referenced
this pull request
Jul 8, 2021
Fixes #606 ### Motivation If a consumer from the same machine subscribed the same topic with a different group id, the `FIND_COORDINATOR` request handler would fail to update the z-node for consumer metrics. In another case, if a consumer from the same machine subscribed the same topic with the same group id again, the KoP side would print redundant error logs like #606. ### Modification - If the z-node existed in `ZooKeeperUtils#tryCreatePath`, update the z-node's data instead of just printing an error log. - Add a unit test to verify group id can be updated successfully.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #606
Motivation
If a consumer from the same machine subscribed the same topic with a different group id, the
FIND_COORDINATORrequest handler would fail to update the z-node for consumer metrics.In another case, if a consumer from the same machine subscribed the same topic with the same group id again, the KoP side would print redundant error logs like #606.
Modification
ZooKeeperUtils#tryCreatePath, update the z-node's data instead of just printing an error log.