support customized labels #157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@mingmcb thx for your contribution! just few suggestions for this PR:
|
ericsyh
reviewed
Sep 28, 2023
| namespace: {{ include "pulsar-resources-operator.namespace" .}} | ||
| labels: | ||
| {{- include "pulsar-resources-operator.labels" . | nindent 4 }} | ||
| {{- toYaml .Values.labels" | nindent 4 }} |
Contributor
There was a problem hiding this comment.
Suggested change
| {{- toYaml .Values.labels" | nindent 4 }} | |
| {{- toYaml .Values.labels | nindent 4 }} |
Contributor
Author
There was a problem hiding this comment.
good catch! please review
ericsyh
reviewed
Sep 28, 2023
| {{- toYaml .Values.podAnnotations | nindent 8 }} | ||
| labels: | ||
| {{- include "pulsar-resources-operator.selectorLabels" . | nindent 8 }} | ||
| {{- toYaml .Values.podLabels" | nindent 8 }} |
Contributor
There was a problem hiding this comment.
Suggested change
| {{- toYaml .Values.podLabels" | nindent 8 }} | |
| {{- toYaml .Values.podLabels | nindent 8 }} |
ericsyh
reviewed
Sep 28, 2023
Contributor
ericsyh
left a comment
ericsyh
left a comment
There was a problem hiding this comment.
Should remove unexpected " in the templates.
ericsyh
reviewed
Sep 29, 2023
| # follow Semantic Versioning. They should reflect the version the application is using. | ||
| # It is recommended to use it with quotes. | ||
| appVersion: "v0.4.3" | ||
| appVersion: "v0.4.4" |
Contributor
There was a problem hiding this comment.
@mingmcb appVersion means the operator image version here.
So for your case, should not change the appVersion here cause your change is only about the chart template and won't need a new operator image.
ericsyh
pushed a commit
that referenced
this pull request
Oct 31, 2023
* support customized labels * clean up the change * Update deployment.yaml * updated per review (cherry picked from commit 2e56e27)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support customized labels
Master Issue: #156
Motivation
to add allow user add customized labels
Modifications
Update the deployment template for new labels
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Documentation
Check the box below.
Need to update docs?
doc-requiredno-need-docthis change is self-explain
doc