Skip to content

refactor(logging): replace standard log with logrus for structured logging#82

Merged
freeznet merged 1 commit intomainfrom
freeznet/logging-function-improve
Feb 26, 2026
Merged

refactor(logging): replace standard log with logrus for structured logging#82
freeznet merged 1 commit intomainfrom
freeznet/logging-function-improve

Conversation

@freeznet
Copy link
Member

@freeznet freeznet commented Feb 26, 2026

No description provided.

@freeznet freeznet self-assigned this Feb 26, 2026
@freeznet freeznet requested a review from a team as a code owner February 26, 2026 02:35
@freeznet freeznet requested a review from Copilot February 26, 2026 02:35
@freeznet freeznet changed the title refactor(logging): replace standard log with logrus for structured lo… refactor(logging): replace standard log with logrus for structured logging Feb 26, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors Pulsar Functions tooling (pkg/mcp/pftools) to use logrus instead of the standard library log, enabling consistent structured log fields in manager operations.

Changes:

  • Add a *logrus.Logger to PulsarFunctionManager and plumb it from the Server wrapper (with a fallback default logger).
  • Replace log.Printf/log.Println calls in the function manager with logrus Info/Warn calls and structured fields.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
pkg/mcp/pftools/types.go Adds a logrus logger field to PulsarFunctionManager.
pkg/mcp/pftools/manager.go Switches manager logging to logrus and updates the internal Server wrapper to carry a *logrus.Logger.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@freeznet freeznet merged commit 910c69a into main Feb 26, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants