Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors Pulsar Functions tooling (pkg/mcp/pftools) to use logrus instead of the standard library log, enabling consistent structured log fields in manager operations.
Changes:
- Add a
*logrus.LoggertoPulsarFunctionManagerand plumb it from theServerwrapper (with a fallback default logger). - Replace
log.Printf/log.Printlncalls in the function manager with logrusInfo/Warncalls and structured fields.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pkg/mcp/pftools/types.go | Adds a logrus logger field to PulsarFunctionManager. |
| pkg/mcp/pftools/manager.go | Switches manager logging to logrus and updates the internal Server wrapper to carry a *logrus.Logger. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jiangpengcheng
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.