Skip to content

docs(network-subgraphs): Update comment about getPermissionId() #1021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2025
Merged

docs(network-subgraphs): Update comment about getPermissionId() #1021

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions packages/network-subgraphs/src/streamRegistry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,10 @@ import { StreamCreated, StreamDeleted, StreamUpdated, PermissionUpdated, Permiss
import { Stream, StreamPermission } from '../generated/schema'
import { MAX_STREAM_ID_LENGTH } from './helpers'

/**
* Hash the streamId and the userId, in order to get constant-length permission IDs (ETH-867)
* This avoids indexing problems if the userId or streamId is very long (many kilobytes).
*
* TODO: after ETH-876 is solved, streamId can't be over-long, remove the slice(0, 1000) below
* because it could cause some streams with same 1k-prefix to mix up when sorting
**/
function getPermissionId(streamId: string, userId: Bytes): string {
// Uses the hash of userId instead of the full ID, since userId can be very long (potentially several kilobytes).
// It's unclear whether there is a strict character limit for ID fields, but in practice, multi-kilobyte IDs can
// cause indexing issues (see ETH-867).
return streamId + "-" + crypto.keccak256(userId).toHexString()
}

Expand Down