Skip to content

Conversation

@teogeb
Copy link
Contributor

@teogeb teogeb commented Jun 17, 2025

Moved StreamrEnvDeployer and HubEnvDeployer classes from network-contracts and hub-contracts subpackages to the dev-chain-fast subpackage. These classes implements the environment initialization logic for the development environment.

As the actual development environment initialization is done in in dev-chain-fast subpackage (which is the exact purpose of that subpackage), it makes sense to move the files there.

Exports

This changes the exports of @streamr/hub-contracts but doesn't change the exports of @streamr/network-contracts because the network-contracts package is published from a different subpackage (npm-network-subgraphs). The actual contracts don't change, just the HubEnvDeployer is removed from the exports. That class may be considered as an internal class and therefore this is not a breaking change. We'll collect all contacts to a separate npm package in the future (ETH-799), and that change will deprecate both of these packages.

Future improvements

We could merge HubEnvDeployer to be part of StreamEnvDeployer

@linear
Copy link

linear bot commented Jun 17, 2025

@teogeb teogeb requested a review from Copilot June 17, 2025 08:41
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the deployment-related modules by moving the environment deployers from the network and hub packages to the dev-chain-fast package.

  • Removed re-exports of deployer classes from network-contracts and hub-contracts
  • Updated import paths in dev-chain-fast to reference the local deployers
  • Reorganized import statements in the StreamrEnvDeployer and HubEnvDeployer modules for consistency

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
packages/network-contracts/src/exports.ts Removed export of StreamrEnvDeployer to decouple from network-contracts
packages/hub-contracts/src/exports.ts Removed export of HubEnvDeployer to decouple from hub-contracts
packages/dev-chain-fast/src/deploy.ts Updated deploy script to import deployers from the local module
packages/dev-chain-fast/src/StreamrEnvDeployer.ts Reorganized and updated import statements to source dependencies locally
packages/dev-chain-fast/src/HubEnvDeployer.ts Updated import source for deployer dependencies to reference hub-contracts
Comments suppressed due to low confidence (1)

packages/dev-chain-fast/src/HubEnvDeployer.ts:4

  • Ensure that the change of import source to "@streamr/hub-contracts" aligns with the intended module organization and that related exports are updated accordingly.
import { ProjectStakingV1, projectStakingV1ABI, projectStakingV1Bytecode,

@teogeb teogeb requested review from harbu and jtakalai June 17, 2025 08:42
Copy link

@jtakalai jtakalai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since CI is green, that should mean the docker image building works (and smoke test passes), so it should Just Work 👍

@teogeb teogeb merged commit 344a872 into main Jun 17, 2025
3 checks passed
@teogeb teogeb deleted the move-deployers-to-dev-chain-fast-subpackage branch June 17, 2025 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants