fix(network-subgraphs): [ETH-876] Ignore overlong stream ids

[teogeb]

Added stream ID length check to all events handlers which process stream related events. If the stream ID is more than 1000 characters, the event is just ignored. That causes the stream to be fully ignored in The Graph (it won't appear e.g. in the streams query).

TODO (in a separate PR)

We need to document to our public document that overlong streams are not supported (i.e. the behavior is undefined in our system for those streams).

Manual test

PRIVATE_KEY="1111111111111111111111111111111111111111111111111111111111111111"
NOW=$(date +%Y%m%d%H%M%S)
LONG_SNIPPET=$(printf 'a%.0s' {1..2000})
echo 'Create streams'
npx tsx bin/streamr.ts internal token-mint self 1000000 1000000 --env dev2 --private-key $PRIVATE_KEY
npx tsx bin/streamr.ts stream create /short1-$NOW --env dev2 --private-key $PRIVATE_KEY
npx tsx bin/streamr.ts stream create /long-$NOW-$LONG_SNIPPET --env dev2 --private-key $PRIVATE_KEY
npx tsx bin/streamr.ts stream create /short2-$NOW --env dev2 --private-key $PRIVATE_KEY
echo 'Wait for The Graph to index'
sleep 10s
echo 'Query streams:'
npx tsx bin/streamr.ts stream search $NOW --env dev2

Related changed

• Simplified getPermissionId() as the slicing and concatenation which is no longer needed

Future improvements

• We could avoid code repetition by using some kind of wrapper function which does the length check

[linear]

ETH-876 Long Stream.id can break The Graph

[jtakalai]

I'll leave a differing opinion here for the record. I don't think this restriction is necessary or useful. Introducing undefined behaviour is unnecessary, so is introducing discrepancy between smart contract state and subgraph state. This has not been done before, and the complexity of that implication is hard to foresee.

These changes have been extensively discussed, however, and since this PR does legitimately fix the original problem of breaking the subgraph, I'm not going to request changes.