Skip to content

Conversation

@teogeb
Copy link
Contributor

@teogeb teogeb commented Nov 28, 2024

Add applicationVersion field to the heartbeat message (published by announceNodeToStream).

Testing

Manually tested that the schema validation in v101 accepts the message which has the additional version field. This test snippet passes in a temp branch which was checked out from the v101.1.2 tag:

it('v102 messages passes validation in v101 schema', () => {
    const msg = {
        "msgType": "heartbeat",
        "peerDescriptor": {
            "nodeId": "nodeId",
            "websocket": {
                "port": 31313,
                "host": "127.0.0.1",
                "tls": false
            }
        },
        "applicationVersion": "102.0.0-beta.1"
    }
    expect(() => HeartbeatMessageSchema.parse(msg)).not.toThrow()
})

@linear
Copy link

linear bot commented Nov 28, 2024

@github-actions github-actions bot added the node label Nov 28, 2024
@teogeb teogeb force-pushed the NET-1381-write-version-to-operator-heartbeats branch from 05c4b7e to 626b5c2 Compare November 28, 2024 12:43
Copy link
Contributor

@mondoreale mondoreale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. See comments.

@teogeb teogeb requested a review from harbu January 22, 2025 13:37
@teogeb teogeb merged commit 549f690 into main Jan 22, 2025
24 checks passed
@teogeb teogeb deleted the NET-1381-write-version-to-operator-heartbeats branch January 22, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants