[NET-1638] implement findProxyNodes in sdk#3257
Merged
Conversation
hpihkala
commented
Dec 4, 2025
juslesan
reviewed
Dec 4, 2025
Contributor
juslesan
left a comment
There was a problem hiding this comment.
Looks OK, a couple of minor comments.
As a heads up we might not support "bidirectional" proxies, meaning that proxies are only able to publish or subscribe to messages on the network level. For the StreamrTV use case we might need to add support for bidirectionality as the viewers need to be able to listen to messages and to send out heartbeats
Contributor
Author
Ah, damn, that complicates things! We will definitely need bidirectionality. I created a ticket and assigned it to you :) |
juslesan
approved these changes
Dec 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
See below bugbot summary.
Checklist before requesting a review
TODOcomments left behind are meant to be left in.Note
Introduce
StreamrClient#findProxyNodesusing a newProxyNodeFinder, updateOperatorRegistry#findOperatorsOnStreamto return operator IDs with peer descriptors, add tests, and remove internalfindOperators.ProxyNodeFinder: discovers proxy nodes from operators with parallelized search.StreamrClient#findProxyNodes(streamDefinition, numberOfProxies, maxQueryResults, maxHeartbeatAgeHours)delegates toProxyNodeFinder.findOperatorsOnStream()now returns{ operatorId, peerDescriptor }instead of peer descriptors only.StreamrClient#findOperators.ProxyNodeFinderunit tests and updateFakeOperatorRegistryto new return type.CHANGELOG.mdreflecting additions and removal.Written by Cursor Bugbot for commit 94ab819. This will update automatically on new commits. Configure here.