This repository was archived by the owner on Dec 21, 2021. It is now read-only.
NET-193: Storage config propagation #227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NET-193 Coordinate testing after storage change
We need to make sure that the automated tests of related projects still pass after NET-32 is merged to master. Especially resend-related tests are vulnerable to breakage after this change. We should especially look into these projects and inform their authors of potentially breakage:
We should probably, to the extent that it is possible, try running the tests ourselves against the new broker branch / docker image, and try to fix any tests we can before merging. |
timoxley
reviewed
Mar 16, 2021
harbu
approved these changes
Mar 17, 2021
teogeb
changed the title
This was referenced Mar 30, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In streamr-dev/broker#211 we will update Broker to store only streams which are explicitly added to that StorageNode. There is only one StorageNode in each environment (production/dev). NOTE: do not merge this before that Broker PR is in master.
Modified
addToStorageNodeto wait until the information has been propagated to the Broker. At that point, we can be sure that any published data will be stored. To enable the propagation check, new client options were added:storageNode.addressandstorageNode.url.Updated also all relevant integration tests: if a test does a resend for some stream, that stream must have been added to a StorageNode.