This repository was archived by the owner on Dec 21, 2021. It is now read-only.
Fix: DU withdraw amount as string #234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timoxley
approved these changes
Mar 24, 2021
Contributor
timoxley
left a comment
timoxley
left a comment
There was a problem hiding this comment.
I'd like to see the test around the exposed interface signWithdrawAmountTo, if that's not too much of a PITA to set up, but otherwise LGTM.
| const actualSignatures = await Promise.all(signaturePromises) | ||
| const expectedSignature = '0x5325ae62cdfd7d7c15101c611adcb159439217a48193c4e1d87ca5de698ec5233b1a68fd1302fdbd5450618d40739904295c88e88cf79d4241cf8736c2ec75731b' // eslint-disable-line max-len | ||
| expect(actualSignatures.every((actual) => actual === expectedSignature)) | ||
| }) |
Contributor
There was a problem hiding this comment.
I feel like we should have a test around signWithdrawAmountTo rather than/in addition to _createWithdrawSignature, since _createWithdrawSignature is just implementation detail for signWithdrawAmountTo.
Contributor
|
Merging this to get it into 5.2 release. My comment on the test is not blocking. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix for
DataUnion.signWithdrawAmountTo().The
amountTokenWeiparameter is typed asBigNumber|number|string, but it if the value is a string the method throws an error:invalid hex string (argument="value", value="...", code=INVALID_ARGUMENT, version=bytes/5.0.10). Fixed the parameter handling by converting the given value to aBigNumber.Fixed also a TypeScript warning by reading the value from
BigNumberviatoHexString()method (which is what the previous implementation did implicitly).