This repository was archived by the owner on Dec 21, 2021. It is now read-only.
Improve "until": Don't evaluate the condition twice if it's true from the beginning #250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timoxley
approved these changes
May 4, 2021
Contributor
timoxley
left a comment
timoxley
left a comment
There was a problem hiding this comment.
Great change, especially if condition is async.
Could add a test?
timoxley
reviewed
May 4, 2021
| }) | ||
| } | ||
|
|
||
| // condition could as well return any instead of boolean, could be convenient sometimes if waiting until a value is returned. Maybe change if such use case emerges. |
Contributor
There was a problem hiding this comment.
boolean is perfectly fine IMO.
any doesn't communicate that we're expecting a truthy or falsey result, and in the worst case someone just needs to do return !!value instead of return value
Also note line length too long.
Contributor
There was a problem hiding this comment.
Ahh I see, you mean it could return the first/last truthy result of calling condition()… interesting.
Probably don't want any for that, instead you'd infer the type from condition, something like:
async function until<T>(condition: MaybeAsync<() => T>, …): Promise<T> => {
…
}
timoxley
reviewed
May 4, 2021
| wasDone = await Promise.resolve().then(condition) // eslint-disable-line no-await-in-loop | ||
| } | ||
| return condition() | ||
| return wasDone |
Contributor
There was a problem hiding this comment.
This can never return false anyway right? it'll always either return true or throw with timeout
timoxley
force-pushed
the
improve-until-util
branch
from
5e01a4d to
4d328cb
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also fix comments