Conversation
bc39f2e to
4e79f09
Compare
5d542b9 to
6d69e2b
Compare
92b817c to
18d0ca0
Compare
18d0ca0 to
e3125a2
Compare
MikeEdgar
left a comment
There was a problem hiding this comment.
At root page of the application I am seeing repeated HTTP 400 errors. It looks like the UI is calling getKafkaCluster to fetch a single cluster with a blank/empty kafkaId.
| {isReconciliationPaused && ( | ||
| <DataListItem aria-labelledby={`reconciliation-warning`}> |
Signed-off-by: hemahg <hhg@redhat.com>
Signed-off-by: hemahg <hhg@redhat.com>
Signed-off-by: hemahg <hhg@redhat.com>
Signed-off-by: hemahg <hhg@redhat.com>
Signed-off-by: Michael Edgar <medgar@redhat.com>
Signed-off-by: hemahg <hhg@redhat.com>
Signed-off-by: hemahg <hhg@redhat.com>
Signed-off-by: hemahg <hhg@redhat.com>
Signed-off-by: hemahg <hhg@redhat.com>
2b71e2f to
a839cf5
Compare
MikeEdgar
left a comment
There was a problem hiding this comment.
One more fix, then good with me. Thanks @hemahg
There is another improvement that can be made in a follow-up PR to hide the pause button when a Kafka cluster's .meta.managed field is false. These Kafka clusters do not have a (known) Kafka CR so we can't pause/resume them.
ui/components/AppLayout.tsx
Outdated
| {isValidKafkaId ? ( | ||
| <ReconciliationProvider kafkaId={kafkaId}> | ||
| <ReconciliationPausedBanner kafkaId={kafkaId} /> | ||
| <ClusterDrawer>{children}</ClusterDrawer> | ||
| </ReconciliationProvider> | ||
| ) : ( | ||
| <></> | ||
| )} |
There was a problem hiding this comment.
This change allows the list of multiple Kafkas to still appear, but blocks the banner if there is no kafkaId.
| {isValidKafkaId ? ( | |
| <ReconciliationProvider kafkaId={kafkaId}> | |
| <ReconciliationPausedBanner kafkaId={kafkaId} /> | |
| <ClusterDrawer>{children}</ClusterDrawer> | |
| </ReconciliationProvider> | |
| ) : ( | |
| <></> | |
| )} | |
| <ReconciliationProvider kafkaId={kafkaId ?? ""}> | |
| {isValidKafkaId && ( | |
| <ReconciliationPausedBanner kafkaId={kafkaId} /> | |
| )} | |
| <ClusterDrawer>{children}</ClusterDrawer> | |
| </ReconciliationProvider> |
Signed-off-by: hemahg <hhg@redhat.com>
|




feat: pause reconciliation
Design link