Skip to content

feat: UI changes for Apicurio integration#1242

Merged
MikeEdgar merged 11 commits intomainfrom
schema-registry
Dec 4, 2024
Merged

feat: UI changes for Apicurio integration#1242
MikeEdgar merged 11 commits intomainfrom
schema-registry

Conversation

@hemahg
Copy link
Contributor

@hemahg hemahg commented Nov 26, 2024

feat: UI changes for Apicurio integration

@hemahg hemahg marked this pull request as draft November 26, 2024 11:57
@hemahg hemahg changed the title [WIP] feat: UI changes for Apicurio integration feat: UI changes for Apicurio integration Nov 29, 2024
@hemahg hemahg marked this pull request as ready for review November 29, 2024 10:06
@hemahg hemahg requested a review from MikeEdgar November 29, 2024 10:06
Copy link
Member

@MikeEdgar MikeEdgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hemahg , it looks good.

Two changes to account for non-JSON schemas and plain text for the format labels. Ignore the comment about how the pages are nested for now, we can address that later.

Signed-off-by: hemahg <hhg@redhat.com>
Copy link
Member

@MikeEdgar MikeEdgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, there is just one typo that I noticed. Otherwise I think we can merge. Thanks

@MikeEdgar MikeEdgar added this to the 0.5.0 milestone Dec 4, 2024
Signed-off-by: hemahg <hhg@redhat.com>
Copy link
Member

@MikeEdgar MikeEdgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MikeEdgar MikeEdgar enabled auto-merge (squash) December 4, 2024 13:12
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 4, 2024

@MikeEdgar MikeEdgar merged commit fdc98ff into main Dec 4, 2024
@MikeEdgar MikeEdgar deleted the schema-registry branch December 4, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants