Migrate to Apicurio 3.1 client libraries#2094
Conversation
...src/main/java/com/github/streamshub/console/api/support/factories/ApicurioClientFactory.java
Show resolved
Hide resolved
efa48a2 to
e89ce50
Compare
b8241a3 to
d9904d3
Compare
3a658e8 to
be870da
Compare
Signed-off-by: Michael Edgar <medgar@redhat.com>
Signed-off-by: Michael Edgar <medgar@redhat.com>
Signed-off-by: Michael Edgar <medgar@redhat.com>
Signed-off-by: Michael Edgar <medgar@redhat.com>
Signed-off-by: Michael Edgar <medgar@redhat.com>
Signed-off-by: Michael Edgar <medgar@redhat.com>
Signed-off-by: Michael Edgar <medgar@redhat.com>
Signed-off-by: Michael Edgar <medgar@redhat.com>
|
@carlesarnal @EricWittmann, FYI if you have some spare cycles to check it and point out potential issues. |
EricWittmann
left a comment
There was a problem hiding this comment.
I'm surprised that the creation of the client facade is as complicated as it needs to be (including providing custom versions of Kiota classes) even though you warned me about it. :)
Despite that, it's pretty straightforward and seems OK to me. I'm less confident in my ability to jude the SerDe stuff. But that seems good to me as well.
The complexity with the client facade comes down to two things, both arising from a common way we allow for clients (Apicurio, Prometheus, & Kafka Connect) to be configured in the console
The custom Kiota stuff will probably be removed now that you've made it configurable in the Apicurio code, but I still have it in there from an earlier iteration. |
|



Uh oh!
There was an error while loading. Please reload this page.