add prometheus integration in recommendation-app #19
Conversation
|
@katheris @tinaselenge , please take a look when available. Thanks. |
katheris
left a comment
katheris
left a comment
There was a problem hiding this comment.
I tried these and found a couple of updates were needed to work on Mac and also a few of the commands were missing -n flink.
More generally I wonder whether the instructions for deploying Prometheus should be in the recommendation-app README, or whether it would be better putting them in the top level README? Do you think we could write the instructions generically so if we added other examples in future it would explain how to use prometheus with any of the examples?
|
Thanks for the review @katheris !
Ah, right! I was testing in Ubuntu, and in my env, I set default namespace as
Good point! I've moved the |
katheris
left a comment
katheris
left a comment
There was a problem hiding this comment.
I think we should assume people will run the commands from the top level directory so I've made some suggestions around that and a wording tweak. Otherwise looks good to me, thanks Luke
|
@katheris @tinaselenge , thanks for the review. Addressed the comments. Thanks. |
|
@kornys , do you have any other comment? |
|
@showuon no, thank you for the fix and PR. |
5 participants
This PR adds the prometheus integration in recommendation-app. This is for local environment demo use. Will add the integration with Openshift cluster built-in Prometheus examples in a separate PR.