Conversation
added 7 commits
June 24, 2020 10:51
We are also adding table tests to that file, this makes the distinction clearer.
It's far more typical to import pandas as pd.
This is a simple table with two columns, one form 1-26 and another from a-z. It'll be used to setup the initial simple tests. The lookup test is added here as well.
We used to set the PYTHONPATH before we started to install the local client using pip. We commented out the old command.
If the pd.Series passed to Column isn't named the same, many operations fail. We now check and set it correctly.
The Table API is easier to implement on a big data processor if its immutable.
Adds 3 merge tests: 1) Merge by both index 2) Merge by left column value on right column index 3) Merge with a rename (columns can only be renamed this way) The test fixtures are slightly changed to add a third column to make testing clearer.
Codecov Report
@@ Coverage Diff @@
## develop #12 +/- ##
===========================================
+ Coverage 92.85% 93.07% +0.21%
===========================================
Files 4 4
Lines 252 260 +8
Branches 22 24 +2
===========================================
+ Hits 234 242 +8
Misses 15 15
Partials 3 3
Continue to review full report at Codecov.
|
added 11 commits
July 1, 2020 08:58
A table's name shouldn't be dynamically changed since Tables are immutable.
A merge results in a new table, if a name is not provided then one is generated. This tests for that behavior.
It previously didn't change and check the new name.
The Github CI was sometimes failing on Mac OS since it couldn't find YAPF. This Makefile leans into using venv directly.
Windows venv bin directory is named Scripts. Beyond that, on Windows, the Makefile was overriding the PYCMD variable instead of SYS_PYCMD.
PYCMD depends on VENV_BIN, but was being set prior to it
Windows venv does not have the python3 command, and the other OS use Python 3 with the python command. It's easier to just use python when using venv.
These commands were not supposed to be added. They are used to push up the website to GCP Kubernetes.
When install yapf on Mac, it's not included in the venv bin by default. Using the python command to call yapf works cross platform. We also do it to coverage to keep things consistent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.