Conversation
added 13 commits
July 16, 2020 18:21
enzyme allow for shallow rendering in unit tests. It requires typescript and enzyme-adapter-react-16 to function properly.
DrawerListLink is a React component that choses between an external a link and a NavLink in the NavDrawer.
We haven't setup pre-commit yet nor CI tests to catch this problem yet.
It was accidently removed in a prior commit.
Fix all automatic vulnerabilities via npm.
external was added as a prop to drawer list by accident. It's a key in the items array since it applies per nav item, not for an entire list.
Render all of the NavLists using a single large data object. This makes things slightly cleaner, easier to change, and easier to test.
serviceWorker is generated by create-react-app and isn't a high priority to test.
These were not added in a past commit with the same tagline. It tests both internal and external links.
The TopBar currently doesn't do much, this just takes a snapshot of the elements that get rendered to check against.
Verifies that NavLists renders all its chidren as expected.
This allows us to catch unexpected changes to the Nav.
This gets more logic out of index.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.