Merged
Conversation
added 3 commits
July 17, 2020 13:07
Keeping a sub-Makefile for each project will be easier to maintain than trying to keep one large one in the base directory.
Python format and check-format were taking forever to run since venv had been moved to the client directory.
Github CI tests are being flaky on Ubuntu. It wants python3-venv to be installed. This forces that to always happen. It slows down the tests, but should end the flakiness.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keeping a sub-Makefile for each project will be easier to maintain
than trying to keep one large one in the base directory.