Conversation
added 4 commits
July 18, 2020 00:18
Using npx pretier --write .
This commit explicitly sets keys for each item in the DrawerLists to fix the warning being printed to the console.
We will have a different workflow for the dashboard and the client so it makes sense to name the files as such.
Uses GitHub actions CI to test dashboard on all 3 OS and using node 12.x and 14.x. It calls into the Makefile.
simba-git
force-pushed
the
feature/simba/dashboard-ci
branch
from
0207311 to
f3c91ed
Compare
added 15 commits
July 18, 2020 00:23
The workflow should only run if the client Makefile, code, or the workflow changes. The workflow yaml file was re-named and the client Makefile was moved into the client/ directory. This updates the paths parameters to match this.
It is re-named to "python_client_unittests" to be more descripitive as we begin adding more job and workflows to the project.
The python-version variable never existed, only the python one did. This resolves that problem.
The version was manually set to 1.0.7 instead of just v1 to fix a previous upstream issue that has since been resolved.
The codecov flags are now python and client which are more helpful and descriptive than just unittests.
The previous workflow was mixing installing dependencies and caching in a single step. It was not compiling correctly. This solves that problem.
This Makefile borrows heavily from the python client one and uses npm to perform most of its work.
This fixes unittets and should work out of the box.
Remove Python 3.5 support from setup.py and removes tests for it in the Python client workflow. pandas requires atleast Python 3.6 to work and we aren't tied to 3.5 at all.
The install rule was renamed into install-dev, but the make dependencies were not updated to reflect this.
setup-python was leftover from copy the python client workflow. It should be using setup-node to get the right node version (though for some reason, it worked anyways)
The setup-node version was set to v2 which doesn't exist. This is because setup-python uses v2. This drops it down to v1.
env_vars was removed from the API in a newer version. This fold in that info into the flags argument.
The file argument wasn't working, this attempts using the coverage directory in its entirety.
Codecov Report
@@ Coverage Diff @@
## develop #18 +/- ##
============================================
- Coverage 93.07% 82.35% -10.73%
============================================
Files 4 4
Lines 260 34 -226
Branches 24 1 -23
============================================
- Hits 242 28 -214
+ Misses 15 6 -9
+ Partials 3 0 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
added 3 commits
July 18, 2020 10:54
Adds a .gitattributes file that changes the EOL character on Windows to \n instead of \r\n. This also should allow JS formatting checks using prettier to pass.
Generating a coverage report in the dashboard also runs all the tests. That means that, prior to this commit, all the tests were being run twice.
If we find a cached version of node_modules, we should use that rather then re-installing all dependencies. The workflow had a bug that checked the venvcache id for a cache hit rather than the nodecache id.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.