Adds ResourceList to Resources tabs.#20
Merged
Conversation
added 10 commits
July 20, 2020 14:56
Adding *.png fixed this, but adding to be explicit in case that is not universally true.
We will use material-table to display sources, features, etc.
Rather than hard-coding the sections in Nav, we inject them in from App component. We have to also hard-code the current version into the Nav test to pass the snapshot test. We could change the snapshot, but I think this is a better test.
The Material-UI framework uses them to power the Icon API. Specifically, they are required for the material-table library to work.
Using enzyme to render MaterialTable requires the HTML canvas API to exist. Importing this dependency mocks it to clear out the error when testing.
Title is a more descriptive name for the parameter than text.
Sources is a material table that will eventually show a list of resources that can be expanded and interacted with.
enzyme-to-jest allows us to use snapshot tests on shallow rendering which is useful for testing top-level components like App.
ResourceList is slightly more descriptive that it is a list, and that it is focused on all resources not just data sources.
Adds a snapshot of a shallow rendering of App to catch any rendering side-effects.
Codecov Report
@@ Coverage Diff @@
## develop #20 +/- ##
============================================
+ Coverage 82.35% 96.55% +14.19%
============================================
Files 4 5 +1
Lines 34 58 +24
Branches 1 2 +1
============================================
+ Hits 28 56 +28
+ Misses 6 2 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
added 3 commits
July 21, 2020 01:19
Now when you click on different Nav links, it will swap the props out for the ResourceLists.
Now when a user enters the dashboard, they will be redirected to the first item in the Nav, and the path will be changed accordingly.
Using `make format` in the dashboard directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.