Conversation
added 4 commits
July 21, 2020 22:54
We will use redux to keep track of app state. Redux-toolkit is an opinionated wrapper over redux which makes typical redux patterns much simpler to implement.
Currently it has no state or reducers attached.
In the future, there may be logic to change the Nav sidebar based on the context (local, hosted, managed) and if the user is paying or not.
NavSections is moved into ReduxState to allow it to be dynamically set and changed according to the context that StreamSQL is deployed. This commit also adds ReduxWrapper which wraps the underlying children with Redux context and a default ReduxStore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NavSections is moved into ReduxState to allow it to be dynamically set
and changed according to the context that StreamSQL is deployed.
This commit also adds ReduxWrapper which wraps the underlying children
with Redux context and a default ReduxStore.