Conversation
added 7 commits
May 5, 2020 14:21
nit: More Pythonic error name since it ends in Error.
The table names are users and purchases, but the pytest fixtures were user and purchase. This made editing the file slightly awkward.
The Table should know its own name. It also makes implementing the Feature API easier.
This field will be used in tests on the Feature API.
Column represents a single column in a table. ML Features can only be applied to single features, so Column is a useful class for implementing features.
NumericFeature is the first piece of the Feature API which allows us to apply common feature engineering operations on source data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NumericFeature is the first piece of the Feature API which allows us to
apply common feature engineering operations on source data.