Conversation
added 2 commits
June 11, 2020 14:41
This rule will allow the CI to make sure that code is properly formatted.
Creates a workflow to test python client and send coverage data. It tests across all python versions >=3.5 and across mac, windows, and linux>
Github actions are failing for Ubuntu due to setuptools not found. Adding it to requirements.txt should resolve this issue.
Codecov Report
|
added 19 commits
June 11, 2020 17:35
Setuptools is an implicit dependency of most python packages. Putting it requirements.txt did not make it download first, but putting it in the CI workflow should.
CI was failing because it was unable to find PATH.
The Windows version of the CI was failing because the python3 command is non-standard. We add a variable to capture that difference.
Windows does not include '.' to the PATH by default typically. This fixes that.
At the moment, v1 points to v1.0.6 which does not externalize their env_vars parameter.
Sometimes py -3 won't be available on Windows, or both python3 and py -3 will be available. In these cases, we chose to go with python3.
We use python virtual environments for development. This adds venv creation into the Makefile.
This simplifies our CI and also is more in-line with how our development is done anyways.
The old venv rule was using ${pycmd} which doesn't exist. It is changed
to use ${PYCMD}.
We do not need this rule anymore for CI since we've switched to using a virtualenv.
CI was failing because virtualenv was not installed. We install it using pip so that it works across all OS we deal with. We can't put it in requirements.txt since it's needed to bootstrap the virtualenv that we then install requirements.txt with.
Rule was defined with a different name then was used in pipeline. 'install-venv' makes more sense, given that the rule to create the virtualenv is 'venv'
Ubuntu doesn't come with setuptools installed by default in Github's action runners.
Ubuntu should use apt-get while MacOS and Windows uses pip.
On non-Windows system, activate is found at ./venv/bin/activate not at ./venv/activate
It's messy to use with CI since the activation doesn't survive past steps. We manually prepend the venv to the path to have a similar effect for now.
The virtualenv in Python has executables under venv/Scripts not venv/bin
For Windows, the venv bin directory is venv/Scripts. This was misspelled in the last commit.
simba-git
force-pushed
the
feature/simba/github-ci
branch
from
3ac0eed to
8354b3d
Compare
In Windows, python3 is not used, its just python.
simba-git
force-pushed
the
feature/simba/github-ci
branch
from
cb65d38 to
699c6ed
Compare
added 2 commits
June 12, 2020 00:21
python3 is atypically seen in Windows and py -3 doesn't exist in virtualenv
Rather than installing the requirements and pointing our PYTHONHOME, we can install the client in edit mode and use it more naturually.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.