Conversation
added 2 commits
June 12, 2020 11:00
Currently the client unit tests always run, they should only run when changes are made to the client directory.
Rather than always installing all pip dependencies, this caches them by operating system.
Codecov Report
@@ Coverage Diff @@
## develop #8 +/- ##
========================================
Coverage 91.91% 91.91%
========================================
Files 4 4
Lines 198 198
Branches 13 13
========================================
Hits 182 182
Misses 13 13
Partials 3 3
Continue to review full report at Codecov.
|
More steps can be skipped if we cache the entire venv as opposed to just the pip requirements.
added 4 commits
June 12, 2020 11:31
The unit tests should be run when the Makefile or the workflow changes. Otherwise, the unit test workflow could change and break, but it won't be run.
run: wasn't included when adding virtualenv
The codecov upload times out randomly. We can ignore those failures for now.
Using the venv cache across python versions may lead to the wrong version of python being used. This form of caching is safer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.