Skip to content

[DXP-1540] Configuration interpolation support #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jgardo-ds merged 10 commits into from
Jan 17, 2025
Merged

[DXP-1540] Configuration interpolation support #157

jgardo-ds merged 10 commits into from
Jan 17, 2025

Conversation

@michalcukierman
Copy link
Contributor

@michalcukierman michalcukierman commented Jan 17, 2025 •
edited
Loading

📋 Type of the Changes

  • Breaking change
  • Non-breaking change
  • Bug fix / minor change

🛠 Changes being made

Configuration interpolation support. Change may be breaking, because $ character needs to be escaped now.

✅ Checklist

  • My code follows the code standards of this project
  • Changed code is covered with unit tests
  • I have updated READMEs and java docs (if applicable)

@michalcukierman michalcukierman requested a review from a team as a code owner January 17, 2025 03:44
pawel-boguski-ds
pawel-boguski-ds approved these changes Jan 17, 2025
View reviewed changes
Copy link

@pawel-boguski-ds pawel-boguski-ds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some readme update with info about the feature would be nice.

kamilchociej
kamilchociej reviewed Jan 17, 2025
View reviewed changes
Copy link
Contributor

@kamilchociej kamilchociej left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you going to work on interpolation support in StreamX Runner?
Should we extract Interpolation logic to shared library?

Ok. NVM. I got it now. Interpolation for runner is applied on streamx run command level. Nice!

@jgardo-ds jgardo-ds changed the title DXP-1540 Configuration interpolation support [DXP-1540] Configuration interpolation support Jan 17, 2025
@jgardo-ds jgardo-ds merged commit 96741ab into main Jan 17, 2025
1 check passed
@jgardo-ds jgardo-ds deleted the feature/DXP-1540-2 branch January 17, 2025 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kamilchociej kamilchociej kamilchociej approved these changes

@pawel-boguski-ds pawel-boguski-ds pawel-boguski-ds approved these changes

+1 more reviewer

@jgardo-ds jgardo-ds jgardo-ds left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@michalcukierman @kamilchociej @pawel-boguski-ds @jgardo-ds