Migrate Count Inputs to Jetpack Compose #6282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westnordost
requested changes
May 23, 2025
Member
westnordost
left a comment
westnordost
left a comment
There was a problem hiding this comment.
Very nice!
There's furthermore with the identical UI (with each different icon):
- Charging station capacity
- Motorcycle parking capacity
app/src/main/java/de/westnordost/streetcomplete/quests/step_count/StepCountForm.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/de/westnordost/streetcomplete/quests/CountForm.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/de/westnordost/streetcomplete/quests/CountForm.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/de/westnordost/streetcomplete/quests/CountForm.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/de/westnordost/streetcomplete/quests/CountForm.kt
Outdated
Show resolved
Hide resolved
# Conflicts: # app/src/androidMain/kotlin/de/westnordost/streetcomplete/quests/bike_parking_capacity/BikeParkingCapacityForm.kt # app/src/androidMain/kotlin/de/westnordost/streetcomplete/ui/common/CountInput.kt # app/src/androidMain/res/layout/compose_view.xml # app/src/androidMain/res/layout/quest_step_count.xml
Member
|
So, seems almost done, only are missing. |
…t-form-composable # Conflicts: # app/src/androidMain/kotlin/de/westnordost/streetcomplete/quests/AddCountInput.kt
Contributor
Author
They are done now |
matkoniecz
reviewed
May 30, 2025
app/src/androidMain/kotlin/de/westnordost/streetcomplete/quests/step_count/AddStepCountForm.kt
Show resolved
Hide resolved
westnordost
approved these changes
May 30, 2025
Member
westnordost
left a comment
westnordost
left a comment
There was a problem hiding this comment.
I like how it is now less lines of code than before. :-)
I fixed some things:
- Dark mode was wrong (missing surface, missing application of app theme)
- also, it just crashed when trying to open the form. It would be good if you tested your work before requesting a review.
- public
@Composables should always have aModifieras parameter - Naming convention for Abstract quest forms is to have that start with (another)
A - parametrized the text style
- after all, I defined a new text style to better describe what it should be used for (-> input fields that are alone in the quest forms, i.e. the only input field. So, they can be very very large)
- finally, what really bugged me during final test, was, that the input fields all started out with a pre-filled "0". So, to input a number, one would think one needs to first delete the 0, then add the number. But this doesn't even work, as the input only accepted ints, not even an empty string. So I changed that. Empty string is fine, too (but doesn't count as "form is filled in")
Member
|
From my side, this could be merged. Would you like to have another look at the changes I made before I merge it? |
Contributor
Author
|
Yes, I've looked it up and it seems fairly complete now! For testing, the emulator was extremely laggy and I couldn't manage to open a quest. Do you use any settings to improve emulation performance? |
Member
|
Yeah, that's a MapLibre problem. The map is super laggy, but you should be able to open the menu -> settings -> show quest forms. No need to deal with the map. |
Member
|
Also, what might help is to set to Graphics Acceleration -> Hardware in the Additional Settings tag when you edit the emulated device. |
github-project-automation
bot
moved this from In Progress
to Done (unreleased)
in iOS Port
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've migrated the following widgets to Jetpack Compose:
I've added Preview for these two Forms.
Let me know if there is any other count input I forgot to migrate to Compose.