Conversation
…plicing. TODO: adjust logic once we get true read start and end in modkit
…hin and cover the entirety of the window used for loading
…. The previous order introduced a bug and failed tests because of strand mismatch. This now passes all tests while maintaining the closer-to-correct read_end information in gapped reads.
…xtract unit tests.
Collaborator
thekugelmeister
left a comment
There was a problem hiding this comment.
Looks good across the board! Some small comments.
thekugelmeister
requested changes
Nov 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Miscellaneous updates in preparation for journal submission. Existing pytest tests all currently pass without changing any pass/fail criteria.
environment.yml: change environment name todimelo-toolkitload_processed.read_vectors_from_hdf5: updates to support new single read browser plots that better show dataspan_full_windowoption. If true, only reads that start before the region_start and end before the region_end are returned, i.e. they must be at least as long as the region. If false, maintain old behavior: all reads that end after the region_start and start before region_end are returned.read_lengthfield for sortingascvsdescorder for each of the sequential sorting operationsparse_bam::read_by_base_txt_to_hdf5: updates to support single reads with long gaps, e.g. RNA with splicingThe new method still misses any read gaps that show up after the last potential modification site: this information will only be available with the modkit upgrade described here: nanoporetech/modkit#270
plot_enrichment_profile::plot_enrichment_profile: update to support profile plots with absolute rather than relative coordinatesplot_enrichment_profilemethods can take inrelativeflag; True means x-axis is centered around region centers, False means x-axis is absolute genome positionsmake_enrichment_profile_plotcan takeoffset_center, which gives a position offset to apply to the plot x-axis (e.g., when plotting absolute genome positions)plot_read_browser::plot_read_browser: update to allow new plot customizations and make it work a bit better with gapped read e.g. RNAutils::DEFAULT_COLORS: add new onesutils::ParsedMotif: fix mod code handling for mod codes more than one character long: the set() function if given a string will give a set of the characters in the string whereas we want in this case a set of string, e.g. "17802" for pseudouridine