[assert] Diff doesn't display pointer vs nil in time.Time

[tobbbles]

When using assert.Equal(t, x, y) and assert.EqualValues(t, x, y), I run into the following issue where it errors but no diff is displayed. After digging down I discovered it's to do with time.Time and whether *time.Location is initialised.

Output from assert:

Error Trace:    store_test.go:70
Error:		Not equal: 
        expected: []*cache.Item{(*cache.Item)(0xc4201a2640), (*cache.Item)(0xc4201a2780)}
        received: []*cache.Item{(*cache.Item)(0xc42021e000), (*cache.Item)(0xc42021e140)}
		
	Diff:

Logging out the structs with "%#v" reveals the difference is in time.Time. See my manual diff below:

- ExpiresAt:time.Time{sec:0, nsec:0, loc:(*time.Location)(nil)},
+ ExpiresAt:time.Time{sec:0, nsec:0, loc:(*time.Location)(0x8bb580)},

[tobbbles]

Note: this is solvable by explicitly setting the time.Time field in the expected struct, via ExpiresAt: time.Unix(0, 0). However I feel this should be handled by assert

[atombender]

I'm surprised you get this, since go-spew, which is used to convert the data to strings for diffing, follows pointers and private fields, so it should be following *time.Location jus tfine. Tested locally with a time.Time value:

(time.Time) {
  sec: (int64) 63616822712,
  nsec: (int32) 709442155,
  loc: (*time.Location)({
    name: (string) "",
    zone: ([]time.zone) <nil>,
    tx: ([]time.zoneTrans) <nil>,
    cacheStart: (int64) 0,
    cacheEnd: (int64) 0,
    cacheZone: (*time.zone)(<nil>)
  })
}

Can you make sure you're on the latest version of go-spew? Your other issue indicates that you're behind.

[georgelesica-wf]

Hello, my name is George. I've recently taken over maintenance of Testify and
I'm excited to help the project move forward.

In order to improve responsiveness and promote contributions to the Testify
project, I have decided to close pull requests and issues that haven't had any
activity in several months and do not appear to address critical bugs.

If you would still like to see your pull request or issue addressed, I am happy
to help! All you have to do is re-open and update it to reflect the current
state of the master branch. Once that is done, I will triage and recruit
reviewers as-needed.

If you have questions, please feel free to reach out. Thank you for your
interest in improving the Testify project!

[gonzaloserrano]

Hi there,

Some links related to this issue, which I think depends on whether a server is in UTC or not:

golang/go#19486
google/go-cmp#139