UI: Edit Grammar Element: support updating composite nodes and HUMAN_TITLE fields #2391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanislaw
force-pushed
the
stanislaw/new_section_included_documents
branch
from
f7677b0 to
79d14e5
Compare
…TITLE fields This change updates the Grammar Element Form to include the new properties IS_COMPOSITE, PREFIX, and VIEW_STYLE as hidden fields. This ensures that saving an element preserves these fields in the resulting SDoc file. In the future, these hidden fields will be converted into regular string/checkbox inputs that users can edit. This change also removes a previously implemented “clever” optimization that skipped saving an element if none of its fields appeared to have changed. Over time, this check became outdated due to the introduction of new features such as HUMAN_TITLE, PROPERTIES/IS_COMPOSITE, PROPERTIES/VIEW_STYLE, and others. Related to: #2193 Closes: #2341
stanislaw
force-pushed
the
stanislaw/new_section_included_documents
branch
from
79d14e5 to
fbdec7a
Compare
stanislaw
changed the title
thseiler
added a commit
to thseiler/strictdoc
that referenced
this pull request
Jul 25, 2025
thseiler
added a commit
to thseiler/strictdoc
that referenced
this pull request
Jul 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the Grammar Element Form to include the new properties IS_COMPOSITE, PREFIX, and VIEW_STYLE as hidden fields. This ensures that saving an element preserves these fields in the resulting SDoc file. In the future, these hidden fields will be converted into regular string/checkbox inputs that users can edit.
This change also removes a previously implemented “clever” optimization that skipped saving an element if none of its fields appeared to have changed. Over time, this check became outdated due to the introduction of new features such as HUMAN_TITLE, PROPERTIES/IS_COMPOSITE, PROPERTIES/VIEW_STYLE, and others.
Closes #2341