fix(sdoc_source_code): correct LineMarker range and add validations #2458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Treat LineMarker as a 1-line range - Validate semantics: disallow consecutive LineMarkers and LineMarker at EOF; raise StrictDocSemanticError. - HTML source: add is_range_marker(); fix range-closer for line/range markers - Update unit/integration tests
stanislaw
approved these changes
Sep 16, 2025
stanislaw
added a commit
that referenced
this pull request
Sep 16, 2025
This change makes both language-aware and unaware parsers to use the same line marker validation function. This is a follow-up to: #2458
stanislaw
added a commit
that referenced
this pull request
Sep 16, 2025
This change makes both language-aware and unaware parsers to use the same line marker validation function. This is a follow-up to: #2458
Collaborator
|
Hey @Mooan, thanks a lot for contributing this! I have opened a follow-up MR that extends your code to also work for Python/C/Robot parsers: #2460. While testing your branch, I also found an unrelated JS bug #2461 which I would like to fix before releasing a new Pip version. If you want to start using the new patch already, feel free to install the Nightly version as described here: https://strictdoc.readthedocs.io/en/latest/latest/docs/strictdoc_01_user_guide.html#3.3-Installing-nightly-StrictDoc-as-a-Pip-package. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This is my first contribution to the project. Thank you for maintaining this excellent tool!
As discussed in Question about line marker specification: @relation(scope=line) targeting behavior thread, I've implemented
Option BLineMarker.Changes:
Please let me know if you need any changes or have any feedback. I'm happy to make adjustments as needed.
Thank you for your time reviewing this!