Skip to content

Conversation

@stanislaw
Copy link
Collaborator

@stanislaw stanislaw commented Nov 23, 2025

This reverts #2565. It should be possible because we found the underlying issue in the lark grammar which broke the integration test on Windows. See #2575.

@stanislaw stanislaw force-pushed the stanislaw/debug_windows_endings branch 2 times, most recently from 1b24685 to ce6cc11 Compare November 25, 2025 21:49
@stanislaw stanislaw changed the title WIP: Debug Windows chore(.gitattributes): remove the LF normalization for test files Nov 25, 2025
@stanislaw stanislaw added this to the 2025-Q4 milestone Nov 25, 2025
This reverts #2565. It should be possible because we found the underlying issue
in the lark grammar which broke the integration test on Windows. See #2575.
@stanislaw stanislaw force-pushed the stanislaw/debug_windows_endings branch from ce6cc11 to 18002a1 Compare November 26, 2025 13:12
@stanislaw
Copy link
Collaborator Author

Thanks @haxtibal, adding instance_bytes = instance_bytes.replace(b"\r\n", b"\n") has worked.

@stanislaw stanislaw merged commit 6f499c5 into main Nov 26, 2025
33 checks passed
@stanislaw stanislaw deleted the stanislaw/debug_windows_endings branch November 26, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants