feat: upgrade to .NET 10, modernise and optimise code#3
Merged
xen2 merged 13 commits intostride3d:masterfrom Apr 7, 2026
Merged
feat: upgrade to .NET 10, modernise and optimise code#3xen2 merged 13 commits intostride3d:masterfrom
xen2 merged 13 commits intostride3d:masterfrom
Conversation
Kryptos-FR
changed the title
- string.Format(...) → $"" interpolated strings throughout
- new List<T>() / new Dictionary<K,V>() → [] collection expressions
- using (x) { } → using x; declarations (FileUtils, AssemblyGen, ResourcesGen, ExtractorCsharp)
- null == / != null → is null / is not null patterns
- ternary null check → ?? null-coalescing (FormatValidator)
- Remove #region/#endregion from AssemblyGen
- Expression-bodied ToConstStr in AssemblyGen
All 17 fixed patterns baked into [GeneratedRegex] partial methods compiled at build time. ProcessPattern now takes Regex instead of string. Only user-supplied custom patterns remain dynamic. Composite const strings are preserved so shared sub-patterns (CsharpStringPattern, TwoStringsArguments- Pattern, etc.) remain visible and reused in the const declarations.
Kryptos-FR
force-pushed
the
features/net10-upgrade
branch
from
e79f95b to
8a9a104
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes stride3d/stride#3113
Also optimise Regex in GNU.Gettext/GNU.Gettext.Xgettext/ExtractorCsharp.cs