fix: Updated Vortice.Vulkan package to the latest version

[Feralnex]

PR Details

Updated Vortice.Vulkan package to the latest version (1.2.167 -> 2.1.2)

Related Issue

Types of changes

• Docs change / refactoring / dependency upgrade
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• My change requires a change to the documentation.
• I have added tests to cover my changes.
• All new and existing tests passed.
• I have built and run the editor to try this change out.

[Eideren]

Looks good, thanks a bunch @Feralnex - did you test a game built under vulkan with these changes ?

[Feralnex]

@Eideren only "New game" example from stride templates. Would be good if somebody with more advanced project could test it before merging

[VaclavElias]

Vortice.Vulkan is now 2.1.0. The linked issue has response fromt the author, if a help is required.

[Feralnex]

Vortice.Vulkan is now 2.1.0. The linked issue has response fromt the author, if a help is required.

Sorry for the delay, I'm still unpacking things (I moved to a new flat). I'll update it in a new year if nobody wants to take it over ; ) I'll come back to Stride in the second part of January or in February

[VaclavElias]

Thanks for an update. Take your time. Hope to see you around once you are settled 🙂.

[Eideren]

Converting this to draft, let us know if/when it is done @Feralnex :)

[Feralnex]

@VaclavElias @Eideren Unfortunately after upgrading to 2.1.1 (and also to 2.1.2) it stopped working. I couldn't find what's wrong so I created an issue amerkoleci/Vortice.Vulkan#58 so that maybe the author might have an idea why it doesn't work anymore (probably some breaking changes in the API) and it's been almost 2 months already without a response. I don't have knowledge to tackle it so if somebody feels like picking it up feel free to do so. Version 1.9.8 from this PR worked without issues for me.

[Eideren]

Thanks ! Left a couple of comments
Would need a quick check from @johang88 if he has time for a quick look over

[johang88]

Thanks ! Left a couple of comments Would need a quick check from @johang88 if he has time for a quick look over

Took a quick look and not seeing any obvious issues! I'll see if I can run it with some of my test projects or maybe merge it into my compute branch if I'm feeling really adventurous.

[johang88]

Seems to work but I get a validation error that is not present on master:

[GraphicsDevice]: Error: vkCreateShaderModule(): SPIR-V Capability Shader was declared, but one of the following requirements is required (VK_VERSION_1_0).
The Vulkan spec states: If pCode is a pointer to SPIR-V code, and pCode declares any of the capabilities listed in the SPIR-V Environment appendix, one of the corresponding requirements must be satisfied (https://vulkan.lunarg.com/doc/view/1.4.309.0/windows/antora/spec/latest/chapters/shaders.html#VUID-VkShaderModuleCreateInfo-pCode-08740)

[Feralnex]

Seems to work but I get a validation error that is not present on master:

[GraphicsDevice]: Error: vkCreateShaderModule(): SPIR-V Capability Shader was declared, but one of the following requirements is required (VK_VERSION_1_0).
The Vulkan spec states: If pCode is a pointer to SPIR-V code, and pCode declares any of the capabilities listed in the SPIR-V Environment appendix, one of the corresponding requirements must be satisfied (https://vulkan.lunarg.com/doc/view/1.4.309.0/windows/antora/spec/latest/chapters/shaders.html#VUID-VkShaderModuleCreateInfo-pCode-08740)

I'll take a look in the coming days, most probably after the weekend

[Feralnex]

Sorry for the wait, I'm pretty busy recently but I've managed to find few mins to investigate. @johang88 could You try again? Might be that in newer version we just need to specify api version upfront

[johang88]

Sorry for the wait, I'm pretty busy recently but I've managed to find few mins to investigate. @johang88 could You try again? Might be that in newer version we just need to specify api version upfront

Seems to work as it should now!

[Eideren]

Thanks !

[Feralnex]

Thanks !

You're welcome! ^^