Skip to content

Conversation

@Jklawreszuk
Copy link
Collaborator

@Jklawreszuk Jklawreszuk commented Dec 6, 2024

PR Details

My PR ports predicates.c logic used in BowyerWatsonTetrahedralization.cs in Stride.Rendering module.
For sake of our usage, I decided to port the functions that are actually used in the Engine thus reducing the number from ~ 4k lines of code to 1.5k.

Related Issue

#1394

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

@Jklawreszuk Jklawreszuk changed the title Port predicates.c to .NET feat: Port predicates.c to .NET Dec 6, 2024
@VaclavElias
Copy link
Contributor

VaclavElias commented Dec 6, 2024

Impressive that some dependencies can be sorted with just a snap of the fingers 🙂.

@Jklawreszuk
Copy link
Collaborator Author

Jklawreszuk commented Dec 6, 2024

I think, this is the last one that requires less effort. Now only the difficult ones remain (Audio, Navigation, VR) 😆

@Jklawreszuk
Copy link
Collaborator Author

Cool, It seems to work 💪

image

@Eideren Eideren merged commit a9ae080 into stride3d:master Dec 6, 2024
4 checks passed
@Eideren
Copy link
Collaborator

Eideren commented Dec 6, 2024

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants