Skip to content

Conversation

@azeno
Copy link
Collaborator

@azeno azeno commented Dec 19, 2024

PR Details

QueryInterface increases the reference count and must be paired with a call to Release.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

@Eideren
Copy link
Collaborator

Eideren commented Dec 22, 2024

Do you guys have time to look into this one @arturoc @tebjan ?

@tebjan
Copy link
Member

tebjan commented Dec 26, 2024

This looks correct! Each interface that one gets with QueryInterface needs to be disposed. Even if the underlying native object is the same or should still exist.

@tebjan tebjan merged commit 154dabf into stride3d:master Dec 26, 2024
2 checks passed
@tebjan
Copy link
Member

tebjan commented Dec 26, 2024

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants