Skip to content

Conversation

@Eideren
Copy link
Collaborator

@Eideren Eideren commented Mar 29, 2025

PR Details

Followup to #2320 - filters that are added by the engine, like UIPage when opening the picker for field of that type, persisted to new instance of the picker, meaning that new pickers for Texture would have a UIPage filter added in as well.
This change ensures that we only persist user-defined filters across instances.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

@Doprez
Copy link
Contributor

Doprez commented Mar 30, 2025

Did some testing here with adding and removing filters as well as opening predefined filtered windows, I dont see any issues here.

LGTM

@Eideren Eideren merged commit c8f9663 into stride3d:master Mar 31, 2025
2 checks passed
@Eideren Eideren deleted the filter_saving branch March 31, 2025 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants