fix: Bepu, ctor with valid orientation for constraints #2777
Conversation
| public sealed class TwistLimitConstraintComponent : TwoBodyConstraintComponent<TwistLimit>, ISpring | ||
| { | ||
| public TwistLimitConstraintComponent() => BepuConstraint = new() { SpringSettings = new SpringSettings(30, 5) }; | ||
| public TwistLimitConstraintComponent() => BepuConstraint = new() |
There was a problem hiding this comment.
I must say, I'm not a fan of the expression body syntax for methods in general and even less for constructors. IMO it should be reserved for property accessors on in rare case when a method redirect to another (e.g. for wrapping types).
There was a problem hiding this comment.
I used them for small methods like these which are easy to read and it removes a few lines. I mean, the readability is still ok 🙂.
There was a problem hiding this comment.
I'm not too keen on it either, but felt that in this case it was warranted as those classes are effectively just wrappers around bepu's constraints. If I were to change that, I would have to change the ~30 other constraint classes, let me know.
There was a problem hiding this comment.
It was just a remark on my side. I guess it's a personal preference and it doesn't warrant a change in this PR
|
That fixes #2680 |
PR Details
Constraints with Quaternion values are not initialized with valid values, this PR ensures that they are initialized to Identity.
Also adds a couple of summaries.
N.B.: I mistakenly made it as a new branch under stride, I'll delete it as soon as I'm done
Related Issue
None reported
Types of changes
Checklist