Skip to content

[Build] fix: Improve StridePlatform determination accuracy#3075

Merged
xen2 merged 1 commit intostride3d:masterfrom
ds5678:stride-platform-detection
Feb 26, 2026
Merged

[Build] fix: Improve StridePlatform determination accuracy#3075
xen2 merged 1 commit intostride3d:masterfrom
ds5678:stride-platform-detection

Conversation

@ds5678
Copy link
Contributor

@ds5678 ds5678 commented Feb 26, 2026

PR Details

This improves the logical consistency for determining StridePlatform, StridePlatforms, and StridePlatformDeps. The files Stride.Build.props, Stride.Core.props, and Stride.Core.targets each failed to have exhaustiveness over the possible platforms.

Related Issue

This is related to #2460 and #1151.

I think this resolves #1151 because I did a text search for StridePlatform and could not find any other places that set the property, but I couldn't actually reproduce the issue being fixed. I think my lack of reproduction is due to MSBuild using old files or something.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

@xen2 xen2 self-requested a review February 26, 2026 14:48
@xen2 xen2 merged commit 13d8cec into stride3d:master Feb 26, 2026
10 checks passed
@ds5678 ds5678 deleted the stride-platform-detection branch February 26, 2026 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

macOS and Linux projects will re-import as Windows

2 participants