Port asset filters and view options to xplat-editor from Wpf#3090
Merged
Kryptos-FR merged 3 commits intostride3d:xplat-editorfrom Apr 8, 2026
Merged
Port asset filters and view options to xplat-editor from Wpf#3090Kryptos-FR merged 3 commits intostride3d:xplat-editorfrom
Kryptos-FR merged 3 commits intostride3d:xplat-editorfrom
Conversation
Author
|
@dotnet-policy-service agree |
Author
|
I just realized there were some files I meant to remove that re-appeared after I tried squashing commits. |
2446c09 to
18c9adc
Compare
18c9adc to
6e1900b
Compare
Closed
Kryptos-FR
requested changes
Mar 22, 2026
Member
Kryptos-FR
left a comment
There was a problem hiding this comment.
Thanks for the contribution. It works well. I have made a few remarks but otherwise LGTM.
Author
I appreciate the feedback. I will get on those requested changes. |
Kryptos-FR
reviewed
Mar 25, 2026
Member
|
@Kryptos-FR I let you merge this one with the timing & merge strategy you prefer, since it's in your dev branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Details
Ports the existing Wpf asset filters and view options. Most of the code is identical to the existing Wpf implementation, but some code was changed or refactored due to Avalonia's differences or new language features.
The following view options were not implemented as the required underlying asset explorer is not functionally complete, but will need to be implemented when the asset explorer is ported over.
I have not added any unit tests yet, but I can do it if requested. Also, happy to implement any feedback.
Related Issue
#2746
Types of changes
Checklist