Skip to content

Port asset filters and view options to xplat-editor from Wpf#3090

Merged
Kryptos-FR merged 3 commits intostride3d:xplat-editorfrom
xianbaum:feature/port-asset-filters
Apr 8, 2026
Merged

Port asset filters and view options to xplat-editor from Wpf#3090
Kryptos-FR merged 3 commits intostride3d:xplat-editorfrom
xianbaum:feature/port-asset-filters

Conversation

@xianbaum
Copy link
Copy Markdown

@xianbaum xianbaum commented Mar 13, 2026

PR Details

Ports the existing Wpf asset filters and view options. Most of the code is identical to the existing Wpf implementation, but some code was changed or refactored due to Avalonia's differences or new language features.

The following view options were not implemented as the required underlying asset explorer is not functionally complete, but will need to be implemented when the asset explorer is ported over.

  • "Assets and folders in selected folder". Asset list currently only shows assets, not folders regardless of the option selected.
  • View as tiles. Can't be implemented until tile view is implemented
  • Zoom in, zoom out. Same reason as above.
  • Asset tags seem unimplemented, so tag filters are implemented, but untested as well.

I have not added any unit tests yet, but I can do it if requested. Also, happy to implement any feedback.

image

Related Issue

#2746

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

@xianbaum
Copy link
Copy Markdown
Author

@dotnet-policy-service agree

@VaclavElias VaclavElias requested a review from Kryptos-FR March 13, 2026 16:34
@xianbaum
Copy link
Copy Markdown
Author

xianbaum commented Mar 13, 2026

I just realized there were some files I meant to remove that re-appeared after I tried squashing commits. Fixing now. Fixed!

@xianbaum xianbaum force-pushed the feature/port-asset-filters branch from 2446c09 to 18c9adc Compare March 13, 2026 19:06
@xianbaum xianbaum force-pushed the feature/port-asset-filters branch from 18c9adc to 6e1900b Compare March 13, 2026 19:35
@Kryptos-FR Kryptos-FR linked an issue Mar 22, 2026 that may be closed by this pull request
@Kryptos-FR Kryptos-FR self-assigned this Mar 22, 2026
Copy link
Copy Markdown
Member

@Kryptos-FR Kryptos-FR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. It works well. I have made a few remarks but otherwise LGTM.

Comment thread sources/presentation/Stride.Core.Presentation.Avalonia/Themes/EditorStyles.axaml Outdated
Comment thread sources/presentation/Stride.Core.Presentation.Avalonia/Controls/SearchComboBox.cs Outdated
Comment thread sources/editor/Stride.Core.Assets.Presentation/ViewModels/AssetViewModel.cs Outdated
Comment thread sources/editor/Stride.Core.Assets.Editor/ViewModels/AssetFilterViewModel.cs Outdated
@xianbaum
Copy link
Copy Markdown
Author

Thanks for the contribution. It works well. I have made a few remarks but otherwise LGTM.

I appreciate the feedback. I will get on those requested changes.

Comment thread sources/editor/Stride.GameStudio.Avalonia/App.axaml Outdated
Copy link
Copy Markdown
Member

@Kryptos-FR Kryptos-FR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks again.

@xen2
Copy link
Copy Markdown
Member

xen2 commented Apr 8, 2026

@Kryptos-FR I let you merge this one with the timing & merge strategy you prefer, since it's in your dev branch.

@Kryptos-FR Kryptos-FR merged commit 02f9e65 into stride3d:xplat-editor Apr 8, 2026
7 of 19 checks passed
@github-project-automation github-project-automation Bot moved this from Review to Done in Avalonia Editor Rewrite Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

❕🟢𝐌 Asset view filters

3 participants