Avalonia test runner: UI revamp#3189
Conversation
|
🤖 Draft PR — automatic CI is skipped to save runner minutes.
Marking ready-for-review re-enables full CI automatically. |
| Icon="/Assets/avalonia-logo.ico" | ||
| Title="XUnit Runner (Stride)"> | ||
| Title="XUnit Runner (Stride)" | ||
| Background="#1E1E1E"> |
There was a problem hiding this comment.
This should use a color from the theme so that if the users prefers a light theme it picks the corresponding background color. Or no color as I think the theme as one by default.
There was a problem hiding this comment.
I remember setting it manually because default was ugly
I thought it was the default but it was simply because it didn't properly apply the theme one.
Adjusting now
There was a problem hiding this comment.
Fixed in latest version
Somehow I had to add it to App.xaml; {DynamicResource SolidBackgroundFillColorBase} didn't work as is.
I wonder if it was really worth the 10+ new lines vs a hardcoded color for this specific dev tool though?
| xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml" | ||
| x:Class="xunit.runner.stride.App" | ||
| RequestedThemeVariant="Light"> | ||
| RequestedThemeVariant="Dark"> |
There was a problem hiding this comment.
Should probably be Default instead so that it follows the system theme.
There was a problem hiding this comment.
I will keep it as is, dark only for now so that I can focus other things & simplify maintenance for now.
(I chose dark to save my poor eyes during those long coding nights ^^)
PR welcome of course if somebody think it's important.
xen2
force-pushed
the
feature/test-runner-ux
branch
from
2adbbd3 to
2bb694c
Compare
xen2
force-pushed
the
feature/test-runner-ux
branch
from
2bb694c to
784321f
Compare
|
Go Xen2 !!! |
…apture, RenderDoc dropdown)
xen2
force-pushed
the
feature/test-runner-ux
branch
from
784321f to
15369b9
Compare
3 participants
Avalonia test runner: UI revamp
Rebuilds the interactive test runner (Avalonia window shown when a Stride test exe is launched with
STRIDE_TESTS_INTERACTIVE=1).Highlights
Ctrl+R/F5shortcuts.Warning:/Error:tinting./orCtrl+Fto focus filter,Escto clear,Up/Down/PageUp/PageDownfrom the filter to navigate the tree,Enter/Shift+Enterto run / preview.A screenshot is worth a thousand words:
Types of changes
Checklist