feat: Rework CharacterController based on Bepu's#3195
Open
Eideren wants to merge 1 commit into
Open
Conversation
Collaborator
Author
|
@xen2 looks like CI is broken, a bunch of unrelated nuget errors ? |
|
hi, since you're doing a rework; could be possible that either in this PR or another to have an Enabled property on Collidables? related to this: #2923 |
Collaborator
Author
|
There are thousands of things that I want to tackle, and I already don't have time to take care of those. I'm sure you'll figure this out |
Member
Sorry about that, on it! |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Details
The implementation for bepu's character controller was a bit wonky;
Related Issue
None logged
Types of changes
Checklist
N.B.:
CharacterControllers.cs,CharacterMotionConstraint.csandCharacterMotionConstraint.ttare effectively copies from bepu's demo. Mostly left as is to make porting new features and fixes introduced over there easier.