[Samples] Misc camera controller fixes#359
Merged
Merged
Conversation
Collaborator
Author
|
Changed to WIP: working on fixing the editor camera. |
Collaborator
Author
|
PR ready for review |
Member
|
Thanks! Tested in editor/new game, it seems to be much better than before. |
Member
|
Merging, thanks for the great work and well commented code! |
Member
|
Note: will cherry-pick this if we release a 3.0.0.8 |
Member
|
@Eideren |
Collaborator
Author
|
@xen2 Well, the third person camera and orbit as well, so all of them sadly.
|
Member
|
@Eideren sure, feel free to create a new issue if you don't mind, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Details
Fix BasicCameraController's mouse input, implements gamepad support, explain in detail common pitfalls of camera controller programming and fixes single frame lag on FPS sample's PlayerInput.
Description
Redondant.
Related Issue
None logged on Github.
Motivation and Context
This mostly stemmed from this Discord discussion I had a couple of weeks ago, creating this PR to fix the issue mentioned lower and clarify controller programming. This camera might very well be the first camera that users interact with, knowing that we might as well document thoroughly how it works and what users should do when modifying or creating one.
Types of changes
Checklist
Notes