Skip to content

Render instal files from Helm Charts, install CRDs, and other smaller changes #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 8, 2024
Merged

Render instal files from Helm Charts, install CRDs, and other smaller changes #60

merged 2 commits into from
Oct 8, 2024

Conversation

@scholzj
Copy link
Member

@scholzj scholzj commented Oct 5, 2024

This PR implements several smaller things:

  • Copies the CRD files to the Helm Chart and not only to the installation files
  • Uses the Helm Chart YAMLs to generate the installation files (apart from the CRD)
  • Extends the check for uncommitted files to include the Helm Chart
  • Fixes the CI pipeline to only push the container images if the system tests pass
  • Updates the way environment variables are defined in the Dockerfile (from deprecated NAME value to NAME=value)

This should revolve #55 and resolve #57.

@scholzj scholzj added this to the 0.2.0 milestone Oct 5, 2024
@scholzj scholzj requested review from a team and katheris October 5, 2024 11:51
@scholzj scholzj force-pushed the render-install-files-from-helm-chart branch from f0dc929 to 0dea7a4 Compare October 5, 2024 13:18
@scholzj
Render instal files from Helm Charts, install CRDs, and other smaller…
7b7f76d 
… changes

Signed-off-by: Jakub Scholz <www@scholzj.com>
@scholzj scholzj force-pushed the render-install-files-from-helm-chart branch from 0dea7a4 to 7b7f76d Compare October 5, 2024 14:05
@scholzj
Fix Helm Chart path in STs
2e7dfb3 
Signed-off-by: Jakub Scholz <www@scholzj.com>
@scholzj scholzj linked an issue Oct 5, 2024 that may be closed by this pull request
Containers should be published only after the STs pass #55
Closed
katheris
katheris approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@katheris katheris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @scholzj, LGTM

@scholzj scholzj merged commit 1499333 into strimzi:main Oct 8, 2024
@scholzj scholzj deleted the render-install-files-from-helm-chart branch October 8, 2024 10:27
scholzj added a commit that referenced this pull request Feb 2, 2025
@scholzj
Render instal files from Helm Charts, install CRDs, and other smaller…
551563a 
… changes (#60)

Signed-off-by: Jakub Scholz <www@scholzj.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ppatierno ppatierno ppatierno approved these changes

@katheris katheris katheris approved these changes

@im-konge im-konge im-konge approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.1.1

Development

Successfully merging this pull request may close these issues.

Generate the installation files out of the Helm Chart Containers should be published only after the STs pass

4 participants

@scholzj @ppatierno @katheris @im-konge