Skip to content

Refactor input validation by introducing requireNonBlank utility method#204

Merged
see-quick merged 1 commit intostrimzi:mainfrom
guancioul:extract-non-blank-string
Apr 14, 2026
Merged

Refactor input validation by introducing requireNonBlank utility method#204
see-quick merged 1 commit intostrimzi:mainfrom
guancioul:extract-non-blank-string

Conversation

@guancioul
Copy link
Copy Markdown
Contributor

Fixed #203,

Extract repeated non-blank string validation into a utility method

Affected methods

  • StrimziKafkaCluster.StrimziKafkaClusterBuilder#withImage
  • StrimziKafkaCluster.StrimziKafkaClusterBuilder#withLogCollection
  • StrimziKafkaCluster.StrimziKafkaClusterBuilder#withSaslUsername
  • StrimziKafkaCluster.StrimziKafkaClusterBuilder#withSaslPassword
  • StrimziKafkaContainer#withLogCollection
  • StrimziKafkaContainer#withSaslUsername
  • StrimziKafkaContainer#withSaslPassword

Signed-off-by: guancioul <guancioul@gmail.com>
Copy link
Copy Markdown
Member

@see-quick see-quick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks @guancioul.

@see-quick see-quick requested a review from a team April 14, 2026 06:01
@see-quick see-quick added this to the 0.116.0 milestone Apr 14, 2026
@see-quick see-quick merged commit 7bc5720 into strimzi:main Apr 14, 2026
7 checks passed
@guancioul guancioul deleted the extract-non-blank-string branch April 14, 2026 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extract repeated non blank string validation into a utility method

3 participants