Skip to content

Conversation

@stringbean
Copy link
Owner

This should make things a bit easier for users.

Before:

XmlCompare.compare(left, right, Set(IgnoreChildOrder))

Becomes:

XmlCompare.compare(left, right, DiffOptions(IgnoreChildOrder))

// or if the default options also needed
XmlCompare.compare(left, right, DiffOptions.default & IgnoreChildOrder)

@stringbean stringbean self-assigned this Oct 2, 2019
@codecov-io
Copy link

codecov-io commented Oct 2, 2019

Codecov Report

Merging #5 into master will decrease coverage by 3.53%.
The diff coverage is 84%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #5      +/-   ##
==========================================
- Coverage     100%   96.46%   -3.54%     
==========================================
  Files           7        8       +1     
  Lines         104      113       +9     
  Branches       13       13              
==========================================
+ Hits          104      109       +5     
- Misses          0        4       +4
Impacted Files Coverage Δ
...tware/purpledragon/xml/scalatest/XmlMatchers.scala 100% <ø> (ø) ⬆️
...software/purpledragon/xml/specs2/XmlMatchers.scala 100% <100%> (ø) ⬆️
...software/purpledragon/xml/compare/XmlCompare.scala 100% <100%> (ø) ⬆️
...purpledragon/xml/compare/options/DiffOptions.scala 55.55% <55.55%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9791b45...7375573. Read the comment docs.

@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2020

Codecov Report

Merging #5 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master        #5   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         8    +1     
  Lines          104       113    +9     
  Branches        13        13           
=========================================
+ Hits           104       113    +9     
Impacted Files Coverage Δ
...tware/purpledragon/xml/scalatest/XmlMatchers.scala 100.00% <ø> (ø)
...software/purpledragon/xml/compare/XmlCompare.scala 100.00% <100.00%> (ø)
...purpledragon/xml/compare/options/DiffOptions.scala 100.00% <100.00%> (ø)
...software/purpledragon/xml/specs2/XmlMatchers.scala 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9791b45...38f057b. Read the comment docs.

@stringbean stringbean merged commit 1d82def into master Jun 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants