Capture stderr when handler closes unexpectedly #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the handler fails, the feedback is currently quite sparse with just "handler closed unexpectedly". Since it may be hard to connect a debugger to the handler process, would be helpful to just dump the stderror output.
For example, all my tests suddenly started failing, and I couldn't reproduce it locally by manually invoking the handler. The current output (narrowed down to just a single test) was:
With this PR, it would be obvious to see that I just forgot to activate my venv:
I'm not a Go dev, so if there are more idiomatic ways of achieving this, please feel free to close / fix as necessary.